Add test for es6 arrow functions #1794
Conversation
|
could you using |
|
I'm fine with that, in fact that was what I originally planned to do but I came across the generator test code decided instead to follow an existing pattern instead. @mikach is there any reason why you went with a Function constructor instead of using |
|
@vincentriemer sorry this got lost in the holidays! could you squish down to a single commit? |
|
Done! |
Add test for es6 arrow functions
|
thanks! |
|
Apologies for commenting in the old thread, just want to comment on what happened with our product today due to this change. We use CI and This check for arrow functions is defined as It adds Modernizr.arrow and I know that I could have added a custom prefix for Modernizr CSS classes on PSA: Please check your styles, please check your CI configs, consider Yarn instead of NPM to lock down deep dependencies, etc. We spent quite a while trying to figure out why our entire web app is wrapped in a tiny box, even though QA gave us a green light during our testing for 2 weeks (until yesterday). |
|
Thanks for the comments, that's a tough one to mitigate when transient
dependencies aren't version locked.
…On Thu, 16 Mar 2017 at 20:51, Kamil Burek ***@***.***> wrote:
Apologies for commenting in the old thread, just want to comment on what
happened with our product today due to this change.
We use CI and 'gulp-moderizr', which depends on 'customizr', which in the
end depends on 'Modernizr' through npm. Thing is, that 3rd level dependency
is not locked to a specific version, so the 3.4.0 release from yesterday
evening slipped into our product through CI.
This check for arrow functions is defined as 'arrow', so far so good.
It adds Modernizr.arrow and 'arrow' class to element, as expected, right?
I know that I could have added a custom prefix for Modernizr CSS classes
on , but since I didn't, it did style my entire app ( element) as an arrow,
because we had some .arrow {} selectors in CSS.
PSA: Please check your styles, please check your CI configs, consider Yarn
instead of NPM to lock down deep dependencies, etc. We spent quite a while
trying to figure out why our page is wrapped in a tiny box, even though QA
was fine.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1794 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIwKkQE3PXN-BoFT4DfRe_Pm_211SR8ks5rmQYNgaJpZM4GvJdi>
.
|
Following the conventions of the ES6 Generators test, added a new test for the ES6 arrow function syntax.
I manually tested the code within the try-catch block and it succeeds in the latest Chrome, Firefox, and Edge but fails in the latest Safari which lines up with this support table.