Add a new base64 encoded h264 video to fix autoplay false negative in Safari #1795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👍 - thanks ryan! |
Member
|
@ryanseddon good to merge? |
ryanseddon
added a commit
that referenced
this pull request
Dec 9, 2015
Add a new base64 encoded h264 video to fix autoplay false negative in Safari
|
Great!!! :) Made my day |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems we had an encoding issue with our h264 test video, created a new video and this seems to fix the problem it's only slightly bigger than the last but has the benefit of actually working
Test case: https://codepen.io/anon/pen/QyWQjQ
Fixes #1692, #1427