Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new base64 encoded h264 video to fix autoplay false negative in Safari #1795

Merged
merged 1 commit into from Dec 9, 2015

Conversation

Projects
None yet
3 participants
@ryanseddon
Copy link
Member

ryanseddon commented Dec 5, 2015

Seems we had an encoding issue with our h264 test video, created a new video and this seems to fix the problem it's only slightly bigger than the last but has the benefit of actually working :trollface:

Test case: https://codepen.io/anon/pen/QyWQjQ

Fixes #1692, #1427

@patrickkettner

This comment has been minimized.

Copy link
Member

patrickkettner commented Dec 5, 2015

👍 - thanks ryan!

@patrickkettner

This comment has been minimized.

Copy link
Member

patrickkettner commented Dec 9, 2015

@ryanseddon good to merge?

ryanseddon added a commit that referenced this pull request Dec 9, 2015

Merge pull request #1795 from Modernizr/autoplay_false_negative
Add a new base64 encoded h264 video to fix autoplay false negative in Safari

@ryanseddon ryanseddon merged commit 3a8d73f into master Dec 9, 2015

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ryanseddon ryanseddon deleted the autoplay_false_negative branch Dec 9, 2015

@MarvelousM

This comment has been minimized.

Copy link

MarvelousM commented Jan 5, 2016

Great!!! :) Made my day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.