Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive in Notifications test for Chrome on Android (fixes #1660) #1813

Merged
merged 1 commit into from Jan 2, 2016
Merged

Fix false positive in Notifications test for Chrome on Android (fixes #1660) #1813

merged 1 commit into from Jan 2, 2016

Conversation

@alexgibson
Copy link
Contributor

@alexgibson alexgibson commented Dec 21, 2015

Please see #1660 for details. Note I don't actually have Chrome for Android to test on. I'm basing the change on this article: https://developers.google.com/web/updates/2015/05/Notifying-you-of-notificiation-changes

new window.Notification('');
} catch (e) {
if (e.name === 'TypeError') {
return false;

This comment has been minimized.

@ryanseddon

ryanseddon Dec 22, 2015
Member

two space indent

return false;
}
}
return true;

This comment has been minimized.

@ryanseddon

ryanseddon Dec 22, 2015
Member

New line above

@ryanseddon
Copy link
Member

@ryanseddon ryanseddon commented Dec 22, 2015

Just tested on a nexus 6 with chrome 45 and it returns no support for notifications with your updated test. Is this correct?

Test case: http://output.jsbin.com/memunosofe/quiet

realdroid_google_nexus_6

@alexgibson
Copy link
Contributor Author

@alexgibson alexgibson commented Dec 22, 2015

Thanks @ryanseddon - yes this is correct, it should return false as only push notifications are now supported in Chrome on Android. Will update these nits shortly.

@alexgibson
Copy link
Contributor Author

@alexgibson alexgibson commented Dec 23, 2015

@ryanseddon updated thanks

@patrickkettner
Copy link
Member

@patrickkettner patrickkettner commented Dec 28, 2015

@alexgibson could you fix the style issue?

@alexgibson
Copy link
Contributor Author

@alexgibson alexgibson commented Dec 29, 2015

@patrickkettner updated

@alexgibson
Copy link
Contributor Author

@alexgibson alexgibson commented Dec 29, 2015

Note: The AppVeyor failure for Node v0.10 looks unrelated to this change (looks like it couldn't install phantomjs for some reason).

@ryanseddon
Copy link
Member

@ryanseddon ryanseddon commented Jan 2, 2016

Yep appveyor seems to fail sometimes for other unrelated reasons.

ryanseddon added a commit that referenced this pull request Jan 2, 2016
Fix false positive in Notifications test for Chrome on Android (fixes #1660)
@ryanseddon ryanseddon merged commit 4666d44 into Modernizr:master Jan 2, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexgibson alexgibson deleted the alexgibson:update-web-notifications-test branch Jan 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants