Fix false positive in Notifications test for Chrome on Android (fixes #1660)#1813
Merged
ryanseddon merged 1 commit intoModernizr:masterfrom Jan 2, 2016
alexgibson:update-web-notifications-test
Merged
Fix false positive in Notifications test for Chrome on Android (fixes #1660)#1813ryanseddon merged 1 commit intoModernizr:masterfrom alexgibson:update-web-notifications-test
ryanseddon merged 1 commit intoModernizr:masterfrom
alexgibson:update-web-notifications-test
Conversation
feature-detects/notification.js
Outdated
Member
|
Just tested on a nexus 6 with chrome 45 and it returns no support for notifications with your updated test. Is this correct? Test case: http://output.jsbin.com/memunosofe/quiet
|
Contributor
Author
|
Thanks @ryanseddon - yes this is correct, it should return false as only push notifications are now supported in Chrome on Android. Will update these nits shortly. |
Contributor
Author
|
@ryanseddon updated thanks |
Member
|
@alexgibson could you fix the style issue? |
Contributor
Author
|
@patrickkettner updated |
Contributor
Author
|
Note: The AppVeyor failure for Node v0.10 looks unrelated to this change (looks like it couldn't install phantomjs for some reason). |
Member
|
Yep appveyor seems to fail sometimes for other unrelated reasons. |
ryanseddon
added a commit
that referenced
this pull request
Jan 2, 2016
Fix false positive in Notifications test for Chrome on Android (fixes #1660)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see #1660 for details. Note I don't actually have Chrome for Android to test on. I'm basing the change on this article: https://developers.google.com/web/updates/2015/05/Notifying-you-of-notificiation-changes