Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive in Notifications test for Chrome on Android (fixes #1660) #1813

Merged
merged 1 commit into from
Jan 2, 2016
Merged

Fix false positive in Notifications test for Chrome on Android (fixes #1660) #1813

merged 1 commit into from
Jan 2, 2016

Conversation

alexgibson
Copy link
Contributor

Please see #1660 for details. Note I don't actually have Chrome for Android to test on. I'm basing the change on this article: https://developers.google.com/web/updates/2015/05/Notifying-you-of-notificiation-changes

new window.Notification('');
} catch (e) {
if (e.name === 'TypeError') {
return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two space indent

@ryanseddon
Copy link
Member

Just tested on a nexus 6 with chrome 45 and it returns no support for notifications with your updated test. Is this correct?

Test case: http://output.jsbin.com/memunosofe/quiet

realdroid_google_nexus_6

@alexgibson
Copy link
Contributor Author

Thanks @ryanseddon - yes this is correct, it should return false as only push notifications are now supported in Chrome on Android. Will update these nits shortly.

@alexgibson
Copy link
Contributor Author

@ryanseddon updated thanks

@patrickkettner
Copy link
Member

@alexgibson could you fix the style issue?

@alexgibson
Copy link
Contributor Author

@patrickkettner updated

@alexgibson
Copy link
Contributor Author

Note: The AppVeyor failure for Node v0.10 looks unrelated to this change (looks like it couldn't install phantomjs for some reason).

@ryanseddon
Copy link
Member

Yep appveyor seems to fail sometimes for other unrelated reasons.

ryanseddon added a commit that referenced this pull request Jan 2, 2016
Fix false positive in Notifications test for Chrome on Android (fixes #1660)
@ryanseddon ryanseddon merged commit 4666d44 into Modernizr:master Jan 2, 2016
@alexgibson alexgibson deleted the update-web-notifications-test branch January 2, 2016 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants