Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Make form-validation output valid code #1824
The form-validation code generates html5 code which doesn't validate as xhtml5 (namely, a missing close-tag and an attribute with no value). This PR fixes that. If you prefer the brevity of vanilla html5 and don't want to cater to the "also valid xml" camp, then feel free to just close this PR (and I will keep it as a custom change for my use, and make a mental note not to submit PRs for any similar changes I might discover in future).
Ah oops. I was just running on automatic when I added the close-tag and didn't even try to grok the surrounding code's intended actions, but of course is a void element [facepalm]. As I presume this has been working fine in non-xml-html5 mode then the xml-equivalent should just be to make the input-tag self-closing (so the just sits before the rather than around/within/connected-to it, yes?). I will update the PR now with that assumption.