Generated content and improvements to injecting elements with styles #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added injectElementwithStyles to replace previous method used in various places
- Not sure seperating the generated content tests is the way to go.
Conflicts: modernizr.js
…tedcontentcsstest3 - testMediaQuery has been replace by injectElementsWithStyles - test_bundle attempts to wrap all tests that use injectElementsWithStyles method into one bundled test that touches the DOM once. - generatedcontentcss3, kinder pointless test for now.
Conflicts: modernizr.js
- This will be more future proof and avoid possible false positive/negatives by isolating each test to it's own element
…injectElementWithStyles method Conflicts: modernizr.js
- Change for loop to reverse while for injectElementWithStyles maybe faster? - Had some commas where semi colons should of been.
|
it is in! thanks so much. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a work in progress
injectElementWithStyles()to refactor tests that need to insert and apply styles.CSS3 generated content.injectElementWithStyles()method.testMediaQuery()is a pointer toinjectElementWithStyles(), should we keep it? It's not exposed to the external API so it shouldn't be a problem removing it?test_bundlebundles all tests that useinjectElementWithStyles()in single call so all these test inject once into the DOM. Improved slightly by isolating bundle tests to their own nodes this way the method will scale for further possible additions.Some ideas
injectElementWithStyles()so the DOM is only touched once.Not sure if I should bother keeping the test for css3 generated content since Opera is the only browser to support it.injectElementWithStyles()if the user selects any tests that use it.