Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links #1838

Merged
merged 1 commit into from Jan 15, 2016
Merged

Update links #1838

merged 1 commit into from Jan 15, 2016

Conversation

@alrra
Copy link
Contributor

@alrra alrra commented Jan 15, 2016

  • Update / Remove broken links.
  • Update links to use HTTPS where possible.
@alrra
Copy link
Contributor Author

@alrra alrra commented Jan 15, 2016

Also, can the project URL be updated to https://modernizr.com/? Thanks!

@@ -8,7 +8,7 @@
"warnings": ["Android < 4 will pass this test, but can only animate a single property at a time"],
"notes": [{
"name" : "Article: 'Dispelling the Android CSS animation myths'",
"href": "http://goo.gl/OGw5Gm"
"href": "https://daneden.me/2011/12/14/putting-up-with-androids-bullshit/"

This comment has been minimized.

@ryanseddon

ryanseddon Jan 15, 2016
Member

We actually short url'd this because the use of bullshit didn't pass some check in visual studio believe it or not https://plus.google.com/u/0/+shanselman/posts/Kfq6eWrueCz?cfem=1

This comment has been minimized.

@alrra

alrra Jan 15, 2016
Author Contributor

Fixed.

We actually short url'd this because the use of bullshit didn't pass some check in visual studio believe it or not https://plus.google.com/u/0/+shanselman/posts/Kfq6eWrueCz?cfem=1

@ralphholzmann Interesting. Btw, the URL doesn't work for me. :(

This comment has been minimized.

@ryanseddon

ryanseddon Jan 15, 2016
Member

Hmm that url worked for me maybe try creating a new one?
On Fri, 15 Jan 2016 at 11:28 AM, Cătălin Mariș notifications@github.com
wrote:

In feature-detects/css/animations.js
#1838 (comment):

@@ -8,7 +8,7 @@
"warnings": ["Android < 4 will pass this test, but can only animate a single property at a time"],
"notes": [{
"name" : "Article: 'Dispelling the Android CSS animation myths'",

Fixed.

We actually short url'd this because the use of bullshit didn't pass some
check in visual studio believe it or not
https://plus.google.com/u/0/+shanselman/posts/Kfq6eWrueCz?cfem=1

@ralphholzmann https://github.com/ralphholzmann Interesting. BTW: that
URL doesn't work for me. :(

https://cloud.githubusercontent.com/assets/1223565/12342082/97f067a2-bb2f-11e5-9ba0-c164cc1c682d.png


Reply to this email directly or view it on GitHub
https://github.com/Modernizr/Modernizr/pull/1838/files#r49807178.

This comment has been minimized.

@ryanseddon

ryanseddon Jan 15, 2016
Member

Oh were you saying the google+ link didn't work? here's a screenshot:

screen shot 2016-01-15 at 13 10 11

This comment has been minimized.

@alrra

alrra Jan 15, 2016
Author Contributor

Oh were you saying the google+ link didn't work?

@ryanseddon Yes.

here's a screenshot:

Thanks!

@ryanseddon
Copy link
Member

@ryanseddon ryanseddon commented Jan 15, 2016

@alrra I've updated the github url to be https

},{
"name": "Mike Taylor Code",
"href": "http://miketaylr.com/code/datalist.html"
"href": "httpis://miketaylr.com/code/datalist.html"

This comment has been minimized.

@ryanseddon

ryanseddon Jan 15, 2016
Member

extra i made it in here

This comment has been minimized.

@alrra

alrra Jan 15, 2016
Author Contributor

Fixed.

* Update / Remove broken links.
* Update links to use HTTPS where possible.
ryanseddon added a commit that referenced this pull request Jan 15, 2016
@ryanseddon ryanseddon merged commit f839e25 into Modernizr:master Jan 15, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ryanseddon
Copy link
Member

@ryanseddon ryanseddon commented Jan 15, 2016

Thanks @alrra

@alrra alrra deleted the alrra:update-links branch Jan 15, 2016
@alrra
Copy link
Contributor Author

@alrra alrra commented Jan 15, 2016

I've updated the github url to be https

@ryanseddon, @patrickkettner While we're at it, can the organization URL also be updated to https://modernizr.com/?

@ryanseddon
Copy link
Member

@ryanseddon ryanseddon commented Jan 16, 2016

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants