Skip to content

Fix preserve3d's IE11/Win10 false positive#1920

Merged
ryanseddon merged 3 commits into
masterfrom
paulirish-patch-1
Aug 4, 2016
Merged

Fix preserve3d's IE11/Win10 false positive#1920
ryanseddon merged 3 commits into
masterfrom
paulirish-patch-1

Conversation

@paulirish

Copy link
Copy Markdown
Member

This is @aFarkas's patch. I'm just helping 😺

fixes #1748

@paulirish

Copy link
Copy Markdown
Member Author

test page: https://output.jsbin.com/bajubol/1/quiet

win7 ie11 - should be false
image

win10 ie11 - should be true
image

lookin good.

@ryanseddon

Copy link
Copy Markdown
Member

Isn't this the preserve3d test looks false on both in your screenshot still?

@paulirish

Copy link
Copy Markdown
Member Author

Isn't this the preserve3d test looks false on both in your screenshot still?

it does appear that is true... :/

@ryanseddon

Copy link
Copy Markdown
Member

@aFarkas is this test missing anything? Seem to be still getting a false negative in win10?

@aFarkas

aFarkas commented Mar 11, 2016

Copy link
Copy Markdown
Member

Not sure, but I think your expectations are wrong. IE11 should always return false (in both cases).

The problem was, that IE11 on Win10 returned true although it should return false. Now it returns always false.

This is also what the title says.

@paulirish Thank you very much to add the modified test (it's so important to avoid layout in modern browsers.)

@ryanseddon

Copy link
Copy Markdown
Member

so if we rebase or merge in master this should be god to go right @paulirish @aFarkas?

@paulirish

Copy link
Copy Markdown
Member Author

Rebased and updated. @aFarkas can you review my logic flip in f9ddfa2 ?

@aFarkas

aFarkas commented Aug 4, 2016

Copy link
Copy Markdown
Member

LGTM

@ryanseddon

Copy link
Copy Markdown
Member

Build failing was a linting issue merged to master so this is good to go, merging.

@ryanseddon ryanseddon merged commit 2a7ddcb into master Aug 4, 2016
@ryanseddon ryanseddon deleted the paulirish-patch-1 branch August 4, 2016 05:46
@paulirish

Copy link
Copy Markdown
Member Author

Ace. Thanks for the followup, @ryanseddon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modernizr.preserve3d returns false positive in IE11 on Windows 10

3 participants