Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for >=6 as chrome rounds down value when page is zoomed #2005

Merged
merged 1 commit into from Jul 15, 2016

Conversation

Projects
None yet
4 participants
@ryanseddon
Copy link
Member

ryanseddon commented Jun 1, 2016

Fixes #1935.

When zoomed >125% in chrome the injected div returns a rounded down height of 6.

Need help to make this is still returning correct results for other browsers.

@patrickkettner

This comment has been minimized.

Copy link
Member

patrickkettner commented Jun 1, 2016

lgtm

@ryanseddon

This comment has been minimized.

Copy link
Member Author

ryanseddon commented Jun 29, 2016

@anthonycosgrave wanna help give this a test?

@anthonycosgrave

This comment has been minimized.

Copy link

anthonycosgrave commented Jun 29, 2016

@ryanseddon Thanks again for your help with this!

I can confirm this fix works and there are no issues at any other zoom levels (50% to 200%) 👍

I've tested with:
Chrome 51.0.2704.106 m on Windows 7 Pro
Chrome 51.0.2704.103 m on Windows Server 2008 R2 Enterprise

@ryanseddon

This comment has been minimized.

Copy link
Member Author

ryanseddon commented Jun 29, 2016

@patrickkettner seems the appveyor build just timed out happy can you kick it of again just to make sure.

@patrickkettner patrickkettner merged commit 49564a7 into master Jul 15, 2016

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@patrickkettner patrickkettner deleted the zoom-rounding-issue-1935 branch Jul 15, 2016

@outaTiME

This comment has been minimized.

Copy link

outaTiME commented Mar 15, 2017

Any update? near future release for this issue? thanks !!!

@ryanseddon

This comment has been minimized.

Copy link
Member Author

ryanseddon commented Mar 15, 2017

@patrickkettner can we cut a release

@patrickkettner

This comment has been minimized.

Copy link
Member

patrickkettner commented Mar 15, 2017

@ryanseddon

This comment has been minimized.

Copy link
Member Author

ryanseddon commented Mar 15, 2017

@patrickkettner can you please document the process too so I can avoid pinging you everytime

@patrickkettner

This comment has been minimized.

Copy link
Member

patrickkettner commented Mar 15, 2017

with pleasure

@patrickkettner

This comment has been minimized.

Copy link
Member

patrickkettner commented Mar 15, 2017

3.4.0 has been released, steps here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.