Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "elem.parentNode is null" with Flashblock #2063

Merged
merged 2 commits into from Sep 2, 2016

Conversation

Projects
None yet
3 participants
@jdelStrother
Copy link
Contributor

jdelStrother commented Aug 31, 2016

The Flashblock Firefox extension seems to take the questionable approach of removing video nodes immediately as they're inserted into the page, which causes an "elem.parentNode is null" error. What do you think to this fix?

@patrickkettner

This comment has been minimized.

Copy link
Member

patrickkettner commented Aug 31, 2016

hey @jdelStrother !
That looks great, could you change it to have smoe curly braces and break it up over a couple lines?

thanks!

@jdelStrother

This comment has been minimized.

Copy link
Contributor Author

jdelStrother commented Aug 31, 2016

Sure, I'll do so tomorrow. (Though if that is the preferred style, shouldn't eslint specify "curly": "all" ? )

@jdelStrother jdelStrother force-pushed the jdelStrother:patch-1 branch from d483db0 to 67cfa5e Aug 31, 2016

@ryanseddon

This comment has been minimized.

Copy link
Member

ryanseddon commented Aug 31, 2016

@jdelStrother good idea want to sneak in the eslint change in this PR and see if our linting still passes if not we can do a follow up PR.

@jdelStrother

This comment has been minimized.

Copy link
Contributor Author

jdelStrother commented Sep 1, 2016

Done. Looks like the rest of the code is already using braces, so I've included the .eslintrc change in this PR. I can break it out if it proves contentious.

@patrickkettner

This comment has been minimized.

Copy link
Member

patrickkettner commented Sep 2, 2016

ah man, perfect use of commits :]

@patrickkettner patrickkettner merged commit 423b121 into Modernizr:master Sep 2, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@patrickkettner

This comment has been minimized.

Copy link
Member

patrickkettner commented Sep 2, 2016

thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.