Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair detect regions #2091

Merged
merged 1 commit into from Feb 21, 2017

Conversation

Projects
None yet
2 participants
@Isthu
Copy link
Contributor

Isthu commented Oct 4, 2016

Detect regions is broken badly. It invokes an undefined property
causing failure to run any detects. The cause is a missing
dependency.

Fixes this by including the missing dependency. Also updates the
references to the free variable style, the correct pattern
in the AMD module architecture.

Fixes #2079

Repair detect regions
Detect regions is broken badly. It references an undefined property
causing failure to run *any* detects. The cause is a missing
dependency.

Fixes this by including the missing dependency. Also updates the
references to the free variable style, the correct pattern
in the AMD module architecture.

Fixes #2079
@Isthu

This comment has been minimized.

Copy link
Contributor Author

Isthu commented Oct 4, 2016

Test of a build with this fix installed. The detect is executed and the outcome is displayed:
http://codepen.io/Isthu/pen/rrYvkB

@ryanseddon ryanseddon merged commit 0b7167e into Modernizr:master Feb 21, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.