Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair detect regions #2091

Merged
merged 1 commit into from Feb 21, 2017
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
+3 −3
Diff settings

Always

Just for now

Repair detect regions

Detect regions is broken badly. It references an undefined property
causing failure to run *any* detects. The cause is a missing
dependency.

Fixes this by including the missing dependency. Also updates the
references to the free variable style, the correct pattern
in the AMD module architecture.

Fixes #2079
  • Loading branch information...
Isthu committed Oct 4, 2016
commit 199c4e69558aaa8d5933822d4c151ff1f0742ffd
@@ -12,7 +12,7 @@
}]
}
!*/
define(['Modernizr', 'createElement', 'docElement', 'isSVG'], function(Modernizr, createElement, docElement, isSVG) {
define(['Modernizr', 'createElement', 'docElement', 'isSVG', 'prefixed'], function(Modernizr, createElement, docElement, isSVG, prefixed) {
// We start with a CSS parser test then we check page geometry to see if it's affected by regions
// Later we might be able to retire the second part, as WebKit builds with the false positives die out

@@ -26,8 +26,8 @@ define(['Modernizr', 'createElement', 'docElement', 'isSVG'], function(Modernizr

/* Get the 'flowFrom' property name available in the browser. Either default or vendor prefixed.
If the property name can't be found we'll get Boolean 'false' and fail quickly */
var flowFromProperty = Modernizr.prefixed('flowFrom');
var flowIntoProperty = Modernizr.prefixed('flowInto');
var flowFromProperty = prefixed('flowFrom');
var flowIntoProperty = prefixed('flowInto');
var result = false;

if (!flowFromProperty || !flowIntoProperty) {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.