Fix localizednumber test. Overwrite the existing value rather than appending text #2093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was always returning false even when the browser and OS were in a Spanish locale.
You can see this for yourself by changing Chrome's default language to Spanish, and loading the Modernizr test page.
The initial value of the input box is
1,0- when wedocument.execCommand('InsertText', false, '1,1')it was prepending to the start of the input value resulting in111,0.By executing
document.execCommand('SelectAll', false)first, we ensure we overwrite the current input value, and the test passes.