Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blacklisting of old Android from fontface.js. Closes #1851 #2095

Merged
merged 1 commit into from Feb 21, 2017
Merged

Remove blacklisting of old Android from fontface.js. Closes #1851 #2095

merged 1 commit into from Feb 21, 2017

Conversation

@PixievoltNo1
Copy link
Contributor

@PixievoltNo1 PixievoltNo1 commented Oct 6, 2016

Usage of pre-2.2 Android versions has fallen below 0.1% (source), so @font-face is practically guaranteed to work on Android. The blacklisting was catching all versions of Firefox for Android.

Usage of pre-2.2 Android versions has fallen below 0.1%*, so @font-face is practically guaranteed to work on Android. The blacklisting was catching all versions of Firefox for Android.

* Source: https://developer.android.com/about/dashboards/index.html
@patrickkettner
Copy link
Member

@patrickkettner patrickkettner commented Oct 6, 2016

honestly, i'd rather fix the ff issue than remove the couple bits of code.

@ryanseddon @SlexAxton thoughts?

@PixievoltNo1
Copy link
Contributor Author

@PixievoltNo1 PixievoltNo1 commented Dec 25, 2016

No comments for 10 weeks. Issue #1851 continues to affect Firefox for Android users. What's next?

I took the approach I did because I think even the guarantee of false positives on Android <2.2 is less important than the chance of another UA-sniffing bug in the future. After all, avoiding UA-sniffing bugs is part of why developers choose Modernizr over UA-sniffing.

@ryanseddon ryanseddon merged commit 2c6e00e into Modernizr:master Feb 21, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants