Remove blacklisting of old Android from fontface.js. Closes #1851 #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of pre-2.2 Android versions has fallen below 0.1%*, so @font-face is practically guaranteed to work on Android. The blacklisting was catching all versions of Firefox for Android. * Source: https://developer.android.com/about/dashboards/index.html
|
honestly, i'd rather fix the ff issue than remove the couple bits of code. @ryanseddon @SlexAxton thoughts? |
|
No comments for 10 weeks. Issue #1851 continues to affect Firefox for Android users. What's next? I took the approach I did because I think even the guarantee of false positives on Android <2.2 is less important than the chance of another UA-sniffing bug in the future. After all, avoiding UA-sniffing bugs is part of why developers choose Modernizr over UA-sniffing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of pre-2.2 Android versions has fallen below 0.1% (source), so @font-face is practically guaranteed to work on Android. The blacklisting was catching all versions of Firefox for Android.