add custom elements detection #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanseddon
reviewed
Feb 21, 2017
feature-detects/custom-elements.js
Outdated
| Detects support for the Custom Elements API, to create custom html elements via js | ||
| */ | ||
| define(['Modernizr'], function(Modernizr) { | ||
| Modernizr.addTest('customelements', typeof window.customElements === 'undefined'); |
There was a problem hiding this comment.
'customElements' in window should be fine
|
Thanks @ryanseddon, changed it. |
What do you mean by this? |
|
I think you reverted your change to config-all.json too |
|
Hey @ryanseddon, I never changed
Well, I was wondering if there is a test to test, that the supportTest is correct? |
|
Hey @ryanseddon can this be merged now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first draft to address #2140.
However, I am at a loss as to how I should add test to test the detection. @ryanseddon could you please advise? Thanks.