Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom elements detection #2155

Merged
merged 1 commit into from Mar 9, 2017

Conversation

Projects
None yet
2 participants
@lukasoppermann
Copy link
Contributor

lukasoppermann commented Feb 6, 2017

This is the first draft to address #2140.

However, I am at a loss as to how I should add test to test the detection. @ryanseddon could you please advise? Thanks.

Detects support for the Custom Elements API, to create custom html elements via js
*/
define(['Modernizr'], function(Modernizr) {
Modernizr.addTest('customelements', typeof window.customElements === 'undefined');

This comment has been minimized.

@ryanseddon

ryanseddon Feb 21, 2017

Member

'customElements' in window should be fine

@lukasoppermann

This comment has been minimized.

Copy link
Contributor Author

lukasoppermann commented Feb 21, 2017

Thanks @ryanseddon, changed it.

@ryanseddon

This comment has been minimized.

Copy link
Member

ryanseddon commented Feb 21, 2017

However, I am at a loss as to how I should add test to test the detection. @ryanseddon could you please advise?

What do you mean by this?

@ryanseddon

This comment has been minimized.

Copy link
Member

ryanseddon commented Feb 21, 2017

I think you reverted your change to config-all.json too

@lukasoppermann

This comment has been minimized.

Copy link
Contributor Author

lukasoppermann commented Feb 22, 2017

Hey @ryanseddon, I never changed config-all.json, added a change now.

However, I am at a loss as to how I should add test to test the detection. @ryanseddon could you please advise?

What do you mean by this?

Well, I was wondering if there is a test to test, that the supportTest is correct?

@lukasoppermann

This comment has been minimized.

Copy link
Contributor Author

lukasoppermann commented Mar 6, 2017

Hey @ryanseddon can this be merged now?

@ryanseddon ryanseddon merged commit 99b6566 into Modernizr:master Mar 9, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.