Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd CSS Grid test for old & new syntaxes #2189
Conversation
KuraFire
added some commits
Apr 13, 2017
This comment has been minimized.
This comment has been minimized.
|
Can you add this to config-all.json too please |
This comment has been minimized.
This comment has been minimized.
|
Normally we have each test separate but I think this makes sense to put it in one since most people will want both. |
patrickkettner
reviewed
Apr 13, 2017
feature-detects/css/cssgrid.js
Outdated
| "name": "The _old_ CSS Grid", | ||
| "href": "https://www.w3.org/TR/2011/WD-css3-grid-layout-20110407/" | ||
| }], | ||
| "warnings": ["`grid-columns` is only in the old syntax, `grid-column` exists in both and so `grid-template-rows` is used for the new syntax."] |
This comment has been minimized.
This comment has been minimized.
patrickkettner
Apr 13, 2017
Member
this isn't really a warning. Warnings should be about the detect themselves (i.e.
This comment has been minimized.
This comment has been minimized.
|
lgtm |
KuraFire
merged commit 6ee39b9
into
master
Apr 13, 2017
ryanseddon
deleted the
feature/css-grid
branch
Apr 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
KuraFire commentedApr 13, 2017
While CSS Grid gets rolled out, it’s useful to have a way to target
IE11 which does not support @supports() but does support old CSS Grid
syntax, as does the new IE14.