Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS Grid test for old & new syntaxes #2189

Merged
merged 3 commits into from Apr 13, 2017

Conversation

Projects
None yet
3 participants
@KuraFire
Copy link
Member

KuraFire commented Apr 13, 2017

While CSS Grid gets rolled out, it’s useful to have a way to target
IE11 which does not support @supports() but does support old CSS Grid
syntax, as does the new IE14.

KuraFire added some commits Apr 13, 2017

Add CSS Grid test for old & new syntaxes
While CSS Grid gets rolled out, it’s useful to have a way to target
IE11 which does not support @supports() but does support old CSS Grid
syntax, as does the new IE14.
Comma lost its way, but eventually found its home
Probably better not to make builds fail.
@ryanseddon

This comment has been minimized.

Copy link
Member

ryanseddon commented Apr 13, 2017

Can you add this to config-all.json too please

@ryanseddon

This comment has been minimized.

Copy link
Member

ryanseddon commented Apr 13, 2017

Normally we have each test separate but I think this makes sense to put it in one since most people will want both.

"name": "The _old_ CSS Grid",
"href": "https://www.w3.org/TR/2011/WD-css3-grid-layout-20110407/"
}],
"warnings": ["`grid-columns` is only in the old syntax, `grid-column` exists in both and so `grid-template-rows` is used for the new syntax."]

This comment has been minimized.

@patrickkettner

patrickkettner Apr 13, 2017

Member

this isn't really a warning. Warnings should be about the detect themselves (i.e. 🚨 giamundo test🚨 , or listing possible edge case failures. Since the end user of modernizr won't need this information, but modernizr developers would, could you move this to a straight up JS comment on line 17?

Updating with Ryan & Patrick's requests
- added new feature detect to lib/config-all.json
- made the notice a JS comment instead of a formal warning
@patrickkettner

This comment has been minimized.

Copy link
Member

patrickkettner commented Apr 13, 2017

lgtm

@KuraFire KuraFire merged commit 6ee39b9 into master Apr 13, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Stexxen Stexxen referenced this pull request Apr 14, 2017

Closed

Feature detect CSS Grid #2168

@ryanseddon ryanseddon deleted the feature/css-grid branch Apr 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.