Add CSS Grid test for old & new syntaxes #2189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While CSS Grid gets rolled out, it’s useful to have a way to target IE11 which does not support @supports() but does support old CSS Grid syntax, as does the new IE14.
Probably better not to make builds fail.
|
Can you add this to config-all.json too please |
|
Normally we have each test separate but I think this makes sense to put it in one since most people will want both. |
feature-detects/css/cssgrid.js
Outdated
| "name": "The _old_ CSS Grid", | ||
| "href": "https://www.w3.org/TR/2011/WD-css3-grid-layout-20110407/" | ||
| }], | ||
| "warnings": ["`grid-columns` is only in the old syntax, `grid-column` exists in both and so `grid-template-rows` is used for the new syntax."] |
There was a problem hiding this comment.
this isn't really a warning. Warnings should be about the detect themselves (i.e. 🚨 giamundo test🚨 , or listing possible edge case failures. Since the end user of modernizr won't need this information, but modernizr developers would, could you move this to a straight up JS comment on line 17?
- added new feature detect to lib/config-all.json - made the notice a JS comment instead of a formal warning
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While CSS Grid gets rolled out, it’s useful to have a way to target
IE11 which does not support @supports() but does support old CSS Grid
syntax, as does the new IE14.