Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Removed some unnecessary checks to make things clearer #568

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

mibalan commented Apr 25, 2012

As pointed by @staabm on #566 (comment) some checks where un-necessary and could leave some stale elements in case they were hit. This commit fixed this.

staabm commented Apr 25, 2012

didn't verified if the actual feature test works, but the memory leaking code-path is gone. thx @mibalan

Contributor

mibalan commented Apr 25, 2012

It should work. Otherwise, that is an error in the Modernizr core if Modernizr.testAllProps('foo') returns true while Modernizr.prefixed('foo') returns false

Owner

paulirish commented Apr 25, 2012

Whoops. I totally missed this PR and already made basically the same exact changes. My bad!
b4681a0

Owner

paulirish commented Apr 25, 2012

Sorry about that :/
Also here's a better view of the change: b4681a?w=1

@paulirish paulirish closed this Apr 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment