fix the assumption that arguments to testProp (etc.) are strings #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
added a commit
that referenced
this pull request
Jul 19, 2012
fix the assumption that arguments to testProp (etc.) are strings
|
Makes sense. thanks! |
patrickkettner
pushed a commit
to patrickkettner/Modernizr
that referenced
this pull request
Feb 22, 2015
fix the assumption that arguments to testProp (etc.) are strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that my change that you merged earlier today introduced a new assumption that the arguments to testProp (etc.) are strings. It occurs to me that this is an additional (and unnecessary) incompatibility with prior versions of Modernizr, so this fixes it to use contains(), which also matches local style better.