SVG filter detection fix #723

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

jbt commented Oct 4, 2012

Fixes a small typo in SVG filter detection.

SVG filter detection fix
Fixes typo in SVG filter detection.
Owner

patrickkettner commented Oct 20, 2013

@jbt I am so sorry we never got back to you on this. Could you explain what situation you were encountering that this fixes? Like what browser, etc?

jbt commented Oct 20, 2013

No worries! Ummm I can't remember exactly where I was using it now - I was just testing filter support in as many browsers as I could think of and just noticed that a typeof is never going to be undefined but always a string - this test was clearly supposed to check whether SVGFEColorMatrixElement is undefined but that's not what it actually does

Owner

patrickkettner commented Oct 22, 2013

Thanks again for the test, and I am really sorry that it took so long for any to get back to you :/

The file structure of the project, and the preferred way of checking for existence has changed, so I updated it with #1078. As a result I am closing this one out.

Thanks again @jbt, really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment