Skip to content

Add test for shape-inside CSS property. #726

Closed
wants to merge 1 commit into from

2 participants

@zhorvath

No description provided.

@paulirish
Modernizr member

hey zoltan.. sorry for the wait.

Do implementations that support shape-inside support ALL or MOST of the exclusions spec? if so i'd rather name this test exclusions?

Just so we can test accurately.. what agents/flags/prototypes support this?

thank you sir!

@zhorvath
zhorvath commented Jan 9, 2013

It only supports shape-inside, not all exclusion stuff. I'm going to extend and turn this test into a more accurate css-exclusions test. Thanks for the comments.

@zhorvath zhorvath closed this Jan 9, 2013
@paulirish
Modernizr member

So here's a little background: https://github.com/Modernizr/Modernizr/wiki/How-We-Test

basically if we can do a Modernizr.testAllProps('shapeInside') and in all known and expected implementations that will imply a "complete" implementation of exclusions then we can and should do that

and more full feature test (what you'd expect in a webkit layouttest) is not necessary or even desirable as its much slower.

know what i mean?

@zhorvath
zhorvath commented Jan 9, 2013

Yes, I got it. Checking only shape-inside property is not enough, I'm going to extend the patch.

@paulirish
Modernizr member
@zhorvath

I sent the request: #786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.