Trim trailing whitespace and insert final newlines #727

Merged
merged 1 commit into from Oct 30, 2012

Projects

None yet

3 participants

@treyhunner

I'm developing a script to check for files with EditorConfig contradictions and a script to fix EditorConfig contradictions. I tested these scripts on the Modernizr codebase and found multiple errors.

This change trims trailing whitespace from all files and inserts final newlines (where missing) into all files.

Important: If there are any dependencies that Modernizr uses but does not directly maintain in this set of changed files, we should probably not change those files and create EditorConfig exceptions for them instead.

@treyhunner

A diff ignoring whitespace demonstrates that no non-whitespace changes were made.

@paulirish
Member

aw shoot
can we re run this after #712 comes in?

@treyhunner

Of course.

The script to fix whitespace is easy for me to run. Indentation still needs to be fixed manually though.

@treyhunner

Ran fix on post-#712 code and updated pull request.

@paulirish paulirish merged commit 8c385d6 into Modernizr:master Oct 30, 2012

1 check failed

Details default The Travis build failed
@paulirish
Member

merged. thank you!

@staabm
staabm commented Oct 30, 2012

maybe the script to fix the whitespaces should be commited into modernizr so it can be re-run in the future?

@treyhunner

@staabm the script isn't done yet, but should be useful to include in build processes once completed.

The script is written in Python so would require a Python interpreter to be run. See jquery/jquery#952 for related discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment