New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTML5 Shiv to latest version #837

Merged
merged 1 commit into from Feb 26, 2013

Conversation

Projects
None yet
6 participants
@drublic
Contributor

drublic commented Feb 25, 2013

This PR updates HTML5 Shiv to the latest version in their repo.
Seems like the printshiv isn't currently included in html5printshiv.js.

This also closes #807.

@paulirish

This comment has been minimized.

Show comment
Hide comment
@paulirish

paulirish Feb 25, 2013

Member

Looks legit. @aFarkas can you review?

Member

paulirish commented Feb 25, 2013

Looks legit. @aFarkas can you review?

@SlexAxton

View changes

Show outdated Hide outdated src/html5printshiv.js
@SlexAxton

View changes

Show outdated Hide outdated src/html5shiv.js
@drublic

This comment has been minimized.

Show comment
Hide comment
@drublic

drublic Feb 26, 2013

Contributor

Updated the PR, @SlexAxton. Didn't notice these two improvements before :/ Silly me!

Contributor

drublic commented Feb 26, 2013

Updated the PR, @SlexAxton. Didn't notice these two improvements before :/ Silly me!

@aFarkas

This comment has been minimized.

Show comment
Hide comment
@aFarkas

aFarkas Feb 26, 2013

Member

Latest version of PR looks fine. Just bumped the same code to version 3.6.2 (final). So you can remove the 'pre' form the HTML5shiv version.

Member

aFarkas commented Feb 26, 2013

Latest version of PR looks fine. Just bumped the same code to version 3.6.2 (final). So you can remove the 'pre' form the HTML5shiv version.

@SlexAxton

This comment has been minimized.

Show comment
Hide comment
@SlexAxton

SlexAxton Feb 26, 2013

Member

I'll pull and update the pre

Member

SlexAxton commented Feb 26, 2013

I'll pull and update the pre

SlexAxton added a commit that referenced this pull request Feb 26, 2013

Merge pull request #837 from drublic/html5shiv-latest
Update HTML5 Shiv to latest version

@SlexAxton SlexAxton merged commit 0157166 into Modernizr:master Feb 26, 2013

1 check passed

default The Travis build passed
Details

@drublic drublic deleted the drublic:html5shiv-latest branch Feb 26, 2013

@drublic

This comment has been minimized.

Show comment
Hide comment
@drublic

drublic Feb 26, 2013

Contributor

Thanks for merging this.

Contributor

drublic commented Feb 26, 2013

Thanks for merging this.

@SlexAxton

This comment has been minimized.

Show comment
Hide comment
@SlexAxton

SlexAxton Feb 26, 2013

Member

Thanks for fixing it!

Member

SlexAxton commented Feb 26, 2013

Thanks for fixing it!

@drublic

This comment has been minimized.

Show comment
Hide comment
@drublic

drublic Feb 26, 2013

Contributor

🍻

Contributor

drublic commented Feb 26, 2013

🍻

@ksheurs

This comment has been minimized.

Show comment
Hide comment
@ksheurs

ksheurs Jun 21, 2013

question - why is this not included in the version @ http://modernizr.com/download/? thx!

ksheurs commented Jun 21, 2013

question - why is this not included in the version @ http://modernizr.com/download/? thx!

@stucox

This comment has been minimized.

Show comment
Hide comment
@stucox

stucox Jun 21, 2013

Member

@ksheurs – it isn't included because we haven't done a new release since this was merged in – it'll be in v3.0, although I'm afraid I can't give you a date when that'll be released just yet...

Member

stucox commented Jun 21, 2013

@ksheurs – it isn't included because we haven't done a new release since this was merged in – it'll be in v3.0, although I'm afraid I can't give you a date when that'll be released just yet...

@ksheurs

This comment has been minimized.

Show comment
Hide comment
@ksheurs

ksheurs Jun 21, 2013

@stucox ah ok cool. no worries! was just confused.. thx.

ksheurs commented Jun 21, 2013

@stucox ah ok cool. no worries! was just confused.. thx.

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015

Merge pull request #837 from drublic/html5shiv-latest
Update HTML5 Shiv to latest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment