Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTML5 Shiv to latest version #837

Merged
merged 1 commit into from Feb 26, 2013
Merged

Conversation

@drublic
Copy link
Contributor

drublic commented Feb 25, 2013

This PR updates HTML5 Shiv to the latest version in their repo.
Seems like the printshiv isn't currently included in html5printshiv.js.

This also closes #807.

@paulirish
Copy link
Member

paulirish commented Feb 25, 2013

Looks legit. @aFarkas can you review?

@SlexAxton
SlexAxton reviewed Feb 25, 2013
View changes
src/html5printshiv.js Outdated
@@ -239,14 +240,14 @@ define(function() {
* // options can be changed before the script is included
* html5 = { 'elements': 'mark section', 'shivCSS': false, 'shivMethods': false };
*/
html5 = {
var html5 = {

This comment has been minimized.

@SlexAxton

SlexAxton Feb 25, 2013 Member

I intentionally leak this higher to the module scope above so we can return it as a module. You should be able to just remove the var.

@SlexAxton
SlexAxton reviewed Feb 25, 2013
View changes
src/html5shiv.js Outdated
@@ -239,14 +240,14 @@ define(function() {
* // options can be changed before the script is included
* html5 = { 'elements': 'mark section', 'shivCSS': false, 'shivMethods': false };
*/
html5 = {
var html5 = {

This comment has been minimized.

@SlexAxton

SlexAxton Feb 25, 2013 Member

Same here.

Closes #807
@drublic
Copy link
Contributor Author

drublic commented Feb 26, 2013

Updated the PR, @SlexAxton. Didn't notice these two improvements before :/ Silly me!

@aFarkas
Copy link
Member

aFarkas commented Feb 26, 2013

Latest version of PR looks fine. Just bumped the same code to version 3.6.2 (final). So you can remove the 'pre' form the HTML5shiv version.

@SlexAxton
Copy link
Member

SlexAxton commented Feb 26, 2013

I'll pull and update the pre

SlexAxton added a commit that referenced this pull request Feb 26, 2013
Update HTML5 Shiv to latest version
@SlexAxton SlexAxton merged commit 0157166 into Modernizr:master Feb 26, 2013
1 check passed
1 check passed
default The Travis build passed
Details
@drublic drublic deleted the drublic:html5shiv-latest branch Feb 26, 2013
@drublic
Copy link
Contributor Author

drublic commented Feb 26, 2013

Thanks for merging this.

@SlexAxton
Copy link
Member

SlexAxton commented Feb 26, 2013

Thanks for fixing it!

@drublic
Copy link
Contributor Author

drublic commented Feb 26, 2013

🍻

@ksheurs
Copy link

ksheurs commented Jun 21, 2013

question - why is this not included in the version @ http://modernizr.com/download/? thx!

@stucox
Copy link
Member

stucox commented Jun 21, 2013

@ksheurs – it isn't included because we haven't done a new release since this was merged in – it'll be in v3.0, although I'm afraid I can't give you a date when that'll be released just yet...

@ksheurs
Copy link

ksheurs commented Jun 21, 2013

@stucox ah ok cool. no worries! was just confused.. thx.

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.