Modernizr crashes on Firefox with hidden iframe #886

Merged
merged 1 commit into from Mar 28, 2013

Projects

None yet

4 participants

@mikkotikkanen
Contributor

On Firefox, with hidden iframes, matchMedia returns null, thus trying to access .matches crashes things. Added extra check to make sure we stay
up and running. Also, added .project to gitignore

@mikkotikkanen mikkotikkanen On Firefox, with hidden iframes, matchMedia returns null, thus trying to
access .matches crashes things. Added extra check to make sure we stay
up and running.
Also, added .project to gitignore
3a4f0a3
@stucox
Member
stucox commented Mar 28, 2013

LGTM, thanks!

@stucox stucox merged commit ef14ae7 into Modernizr:master Mar 28, 2013

1 check passed

default The Travis build passed
Details
@codeofsumit

i still have this issue with the latest version of modernizr and firefox

@stucox
Member
stucox commented Mar 3, 2014

This fix will be in v3.0.0, unless you ask @patrickkettner very nicely to back-port it to 2.x.

@patrickkettner patrickkettner added a commit to patrickkettner/Modernizr that referenced this pull request Apr 29, 2014
@patrickkettner patrickkettner backport of ef14ae7 / #886 535405e
@patrickkettner
Member

This was released in v2.8.0

@mikkotikkanen mikkotikkanen deleted the mikkotikkanen:testMediaQuery branch May 6, 2014
@stucox stucox referenced this pull request May 21, 2014
Closed

v3.0 release notes #805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment