New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernizr crashes on Firefox with hidden iframe #886

Merged
merged 1 commit into from Mar 28, 2013

Conversation

Projects
None yet
4 participants
@mikkotikkanen
Contributor

mikkotikkanen commented Mar 28, 2013

On Firefox, with hidden iframes, matchMedia returns null, thus trying to access .matches crashes things. Added extra check to make sure we stay
up and running. Also, added .project to gitignore

On Firefox, with hidden iframes, matchMedia returns null, thus trying to
access .matches crashes things. Added extra check to make sure we stay
up and running.
Also, added .project to gitignore
@stucox

This comment has been minimized.

Member

stucox commented Mar 28, 2013

LGTM, thanks!

stucox pushed a commit that referenced this pull request Mar 28, 2013

Stu Cox
Merge pull request #886 from mikkotikkanen/testMediaQuery
Modernizr crashes on Firefox with hidden iframe

@stucox stucox merged commit ef14ae7 into Modernizr:master Mar 28, 2013

1 check passed

default The Travis build passed
Details
@codeofsumit

This comment has been minimized.

codeofsumit commented Mar 3, 2014

i still have this issue with the latest version of modernizr and firefox

@stucox

This comment has been minimized.

Member

stucox commented Mar 3, 2014

This fix will be in v3.0.0, unless you ask @patrickkettner very nicely to back-port it to 2.x.

patrickkettner added a commit to patrickkettner/Modernizr that referenced this pull request Apr 29, 2014

@patrickkettner

This comment has been minimized.

Member

patrickkettner commented Apr 29, 2014

This was released in v2.8.0

@mikkotikkanen mikkotikkanen deleted the mikkotikkanen:testMediaQuery branch May 6, 2014

@stucox stucox referenced this pull request May 21, 2014

Closed

v3.0 release notes #805

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015

Stu Cox
Merge pull request Modernizr#886 from mikkotikkanen/testMediaQuery
Modernizr crashes on Firefox with hidden iframe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment