Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keyv@4 support #4

Merged
merged 1 commit into from
Jan 5, 2021
Merged

add keyv@4 support #4

merged 1 commit into from
Jan 5, 2021

Conversation

Kikobeats
Copy link
Contributor

@Kikobeats Kikobeats commented Jan 5, 2021

Hello,

I was using memoized-keyv with keyv@4 for long time, so I'm sure it's fully compatible.

This change is necessary to make memoized-keyv compatible with Node 15.x since right now it's throwing an error:

npm install --production
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: microlink-api@2.22.22
npm ERR! Found: keyv@4.0.3
npm ERR! node_modules/keyv
npm ERR!   keyv@"~4.0.3" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer keyv@"^1 || ^2 || ^3" from memoized-keyv@1.1.2
npm ERR! node_modules/memoized-keyv
npm ERR!   memoized-keyv@"~1.1.2" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/kikobeats/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/kikobeats/.npm/_logs/2021-01-05T11_24_32_537Z-debug.log

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fa5342b on Kikobeats:patch-1 into 0e48efb on Moeriki:master.

@moeriki moeriki merged commit cfee891 into moeriki:master Jan 5, 2021
@moeriki
Copy link
Owner

moeriki commented Jan 5, 2021

Thanks! I published v1.2.

@Kikobeats Kikobeats deleted the patch-1 branch January 5, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants