utils: remove always true parameter #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
All right, let's move this to v4.0.0 then? I'll keep it as a draft until then and you can mark it as ready and merge it. |
|
@MohammadYounes will the next release be a major version bump (4.0.0)? If so we could drop Node.js 10 support and land more stuff. |
|
@XhmikosR Yes, it would be great if you finalize other PRs as well. |
|
I'll do but better wait until postcss is fixed and we unpin the dep before making the new release. |
|
that's the plan👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are internal functions AFAICT and the
indexedparameter is always true. Not sure if there's something else I might be missing; if so let me know :)Non-whitespace diff: https://github.com/MohammadYounes/rtlcss/pull/270/files?w=1