Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added copyright header, LICENSE, and #8

merged 4 commits into from Sep 26, 2018


None yet
2 participants
Copy link

commented Sep 24, 2018

Preparation for OSS :)

@Dinnerbone Dinnerbone force-pushed the feature/copyright branch from 5fbf579 to 63a76c5 Sep 24, 2018

@Dinnerbone Dinnerbone force-pushed the feature/copyright branch from 63a76c5 to e54a50f Sep 25, 2018


boq approved these changes Sep 26, 2018

Command registration also encourages use of a builder pattern to keep code cruft to a minimum.

A "command" is a fairly loose term, but typically it means an exit point of the command tree.

This comment has been minimized.

Copy link

boq Sep 26, 2018


I'd argue that most people identify command by first literal after root, so that would make "command" a sub-tree and not just path leading to leaf node. /bikeshedding

@Dinnerbone Dinnerbone merged commit 8e9859e into master Sep 26, 2018

2 checks passed

continuous-integration/teamcity Finished TeamCity Build Minecraft (PC Java) / Tools / Brigadier / Build : Tests passed: 195
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.