Enable notebook syntax highlighting #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The symptom is that local builds correctly have syntax highlighting in the output builds, but on RTD, they are lacking. Based on research from readthedocs/readthedocs.org#5688 the problem comes from the multiple warnings of: > WARNING: Pygments lexer name 'ipython3' is not known We do see this in our RTD builds as well: https://readthedocs.org/api/v2/build/9139203.txt Based on that issue and spatialaudio/nbsphinx#24, The fix to this issue is to add `ipython` to the requirements.txt explicitly. So, this PR tries that
|
Sure, lets try. |
dgasmith
approved these changes
Jul 19, 2019
|
Sure, lets try. |
|
Hey! Syntax!
|
|
Great! Can you fix Fractal as well? |
|
Sure thing |
Lnaden
added a commit
to Lnaden/QCFractal
that referenced
this pull request
Jul 19, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symptom is that local builds correctly have syntax highlighting
in the output builds, but on RTD, they are lacking.
Based on research from readthedocs/readthedocs.org#5688 the problem
comes from the multiple warnings of:
We do see this in our RTD builds as well: https://readthedocs.org/api/v2/build/9139203.txt
Based on that issue and spatialaudio/nbsphinx#24, The fix to this issue is to add
ipythonto the requirements.txt explicitly. So, this PR tries that.cc @dgasmith