CI: GHA Test #173
Merged
CI: GHA Test #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lint check isn't picking up configuration settings and failing. Very odd. |
|
iSort isn't picking up We originally pushed back against the lint checker as we were worried that it would hinder submissions as too complex. As we now have the |
loriab
reviewed
Dec 2, 2019
loriab
approved these changes
Dec 6, 2019
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -7,4 +7,5 @@ | |||
| <!-- Provide a brief single sentence for the changelog. --> | |||
|
|
|||
| ## Status | |||
| - [ ] `make format` run on the codebase (may have to `conda install black isort autoflake -c conda-forge` or `pip install black isort autoflake`) | |||
There was a problem hiding this comment.
I took the liberty of adding this directly to your branch, so feel free to tweak/object.
|
oh, and there's a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tries out the GHA CI pr integration and updates the status badge.
Changelog description
Status