Add plain msgpack serialization #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loriab
reviewed
Jun 29, 2021
There was a problem hiding this comment.
may want to look at the below if haven't already:
- https://github.com/MolSSI/QCElemental/blob/master/qcelemental/models/molecule.py#L983
- https://github.com/MolSSI/QCElemental/blob/master/qcelemental/tests/test_molecule.py#L209 (those
to_filelook likedtype=dtypeneeded) - https://github.com/MolSSI/QCElemental/blob/master/qcelemental/tests/test_molecule.py#L240
- https://github.com/MolSSI/QCElemental/blob/master/qcelemental/util/__init__.py#L28
|
Added to the init file and fixed the test. I guess I didn't need to fix the test, since For the to/from file, I removed the |
loriab
reviewed
Jun 29, 2021
Co-authored-by: Lori A. Burns <lori.burns@gmail.com>
loriab
reviewed
Jun 29, 2021
loriab
reviewed
Jun 30, 2021
| elif dtype == "msgpack-ext": | ||
| with open(filename, "rb") as infile_bytes: | ||
| data = deserialize(infile_bytes.read(), encoding="msgpack-ext") | ||
| dtype = "dict" |
There was a problem hiding this comment.
since for reading json=json-ext and msgpack=msgpack-ext, aren't only 2 if's needed?
There was a problem hiding this comment.
Yes, although we should make it explicit. Ie, for json, use json-ext and for msgpack, use msgpack-ext (with comment that the -ext are backwards compatible)
loriab
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ability to serialize to plain msgpack format.
The current
msgpack-extencoding serializes numpy arrays as numpy arrays, which is not portable (that is, deserializing would require python and qcelemental). This adds a plainmsgpackencoding that converts numpy arrays to lists, as is done with the existingjsonencoding.Changelog description
Adds plain msgpack serialization
Status