from_data to dtype=2 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 840eb60 into bcc7a28 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
Can you rebase this for the history? |
|
Didn't mean for this to supersede #42, unless you're confident it's harmless to downstream. Which do you want to proceed with? |
|
It isn't completely harmless downstream as hashes change, but we need it in to start computing I think. |
|
ok, rebased. clean pass locally, so clear for rev/merge after CI |
|
This pull request introduces 1 alert when merging 729493a into bcc7a28 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
… removing too much data
|
This pull request introduces 1 alert when merging ac3a292 into 1dfc906 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1 commit)
could cause problems downstream
needs rebase after #42 merged