Add display of number of records in a dataset#762
Merged
Conversation
|
Awesome - this looks great! Sorry it took me so long, just got to this as you were merging. Thanks for putting this in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the number of records in a dataset to the
list_datasetsfunctionality, and also the ability to request from the server the number of records in a dataset via the dataset model (ds.record_count). Requested in issue #756The record count is computed on the fly. For now, this is fine, but we will have to keep an eye on it as the database size increases, though, as then listing dataset size could take too long. There could be more database trickery we could do.
Example output from
print_dataset_list(for a small subset of the production database):Changelog description
Add display of number of records in a dataset, and ability to get number of records in a dataset
Status