Conversation
Contributor
Author
|
This looks really slick! I'd be happy with it. I'll ping @dotsdl directly in case he (like me) didn't see the notification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve printing of task status and information in compute manager logs
Information now is printed as tables and now include
record_id, which is distinct fromtask_id.In general,
task_idis rarely useful, and often confused withrecord_id, so we print both explicitly.Now, two tables are printed. The first is when computations are found to be finished, and includes executor, walltime, and error information.
The second displays the status of records being sent back to the server (whether they are accepted, rejected, or deferred due to server downtime/network issues).
Changelog description
Improve manager logging of task information
Status