Skip to content

Improve manager logging of task information#773

Merged
bennybp merged 3 commits intomainfrom
manager_tasks
Oct 18, 2023
Merged

Improve manager logging of task information#773
bennybp merged 3 commits intomainfrom
manager_tasks

Conversation

@bennybp
Copy link
Copy Markdown
Contributor

@bennybp bennybp commented Oct 14, 2023

Description

Improve printing of task status and information in compute manager logs

Information now is printed as tables and now include record_id, which is distinct from task_id.
In general, task_id is rarely useful, and often confused with record_id, so we print both explicitly.

Now, two tables are printed. The first is when computations are found to be finished, and includes executor, walltime, and error information.

  task id    record id  executor    walltime    status
---------  -----------  ----------  ----------  --------------------
        3            4  local       00:00:2.74  success
        4            5  local       00:00:2.74  success
        5            6  local       00:00:2.52  error: unknown_error

The second displays the status of records being sent back to the server (whether they are accepted, rejected, or deferred due to server downtime/network issues).

  task id    record id  status    reason
---------  -----------  --------  -------------------------------------
        3            4  sent
        4            5  sent
        5            6  rejected  Task does not exist in the task queue

Changelog description

Improve manager logging of task information

Status

  • Code base linted
  • Ready to go

@bennybp
Copy link
Copy Markdown
Contributor Author

bennybp commented Oct 16, 2023

Just wondering if you have any comments @j-wags or @dotsdl. Any additional info you would find useful?
You are some of the few people to run a manager :)

@bennybp bennybp changed the title [WIP] Improve manager logging of task information Improve manager logging of task information Oct 16, 2023
@j-wags
Copy link
Copy Markdown

j-wags commented Oct 17, 2023

This looks really slick! I'd be happy with it. I'll ping @dotsdl directly in case he (like me) didn't see the notification.

Copy link
Copy Markdown
Collaborator

@dotsdl dotsdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @bennybp! Thanks for adding these!

@bennybp bennybp merged commit 2c6890d into main Oct 18, 2023
@bennybp bennybp deleted the manager_tasks branch October 18, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants