Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove client/manager version checks against what the server reports.
Starting in 0.51, backwards-incompatible changes to the API will be handled by changing the version in the URI
(ie,
/api/v1/datasets->/api/v2/datasets). This will be done only on the endpoints that do change.The
v1API's will left in place, so older clients will still work with newer servers.If a new client detects an old server, a warning is printed. The main hazard there is that the client may want new features the server does not provide.
Starting with QCFractal v1.0, we should move to semver, so we could at least check major versions between client and server. This would allow us to remove the older versioned endpoints.
Changelog description
Removed forced version checks between client and server
Status