Add automatic batching in ds.add_entries() and ds.submit()#775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Trying to add a large number of entries can cause a timeout on the server. This adds automatic batching (with progress bars) so that this doesn't happen.
Also adds similar functionality to
submit().In the future,
submit()(and maybeadd_entries()) should move to an asynchronous operation, where an internal job is created, which can be viewed/polled with some future-like object.See openmm/spice-dataset#82 for some motivation, although that's not the only one.
Changelog description
Add automatic batching in ds.add_entries() and ds.submit()
Status