Enable Pydantic v1/v2 dual-compatibility#787
Merged
Merged
Conversation
As it says. This is a stopgap until we can properly implement Pydantic v2
Collaborator
|
I don't have official powers here at qcf, so merge decision/schedule is all @bennybp . |
Contributor
|
Thanks! I also removed the pins in some testing environments. I remember there being some error with |
Contributor
Author
|
My guess is you're thinking of this issue: MolSSI/QCElemental#312 In which case it's still a problem, but under the umbrella of changes required to leverage the v2 API. Since this just allows access to v1 via v2 I think that can still be pushed into the future. |
Contributor
|
Oh yes, of course :) Thanks for finishing this up! |
Contributor
Author
|
Thank you! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is my attempt at taking #736 over the finish line
Changelog description
Status
closes #736