Improve task queue performance#811
Merged
Merged
Conversation
bennybp
force-pushed
the
task_queue
branch
2 times, most recently
from
e0e0646 to
e7036e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplifies the task queue. Now, the queue will store a timestamp used to sort tasks. By default, it is the time the row is added, however services will overwrite this with the created_on time of the service itself. This allows for services to finish relatively in order, without waiting for tasks from all other services to finish.
This behavior was already present, however the query to determine the next tasks was pretty gnarly and expensive. This is now replaced by a very simple, indexed query on one table.
Supersedes #810
Changelog description
Improves task queue performance
Status