Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the use of sqlite3 from the python standard library with APSW (https://github.com/rogerbinns/apsw, https://rogerbinns.github.io/apsw/index.html)
APSW is a lightweight wrapper around sqlite that allows for more features compared to the python standard library (which is constrained by the DB API).
In particular, APSW allows for multi-threaded access to connections, which means I can remove some kinda hacky thread-local stuff. And since I can remove that, I don't need to use the memdb vfs, which seems constrained in the size of the db (whereas
:memory:seems unconstrained). So that should prevent things like #820It also allows for some more advanced features that I may use in the future.
Changelog description
Replace use of Python sqlite3 with APSW
Status