Extras field of records should not be None/NULL#854
Merged
Conversation
|
Awesome, thanks Ben! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
extrasfield ofbase_record(therefore all records) should probably not be null. It's more consistent that it's a dict, even if it's empty.The original idea is that
extrasis only populated on record completion. ButThis inconsistency has caused problems for some users as well: openforcefield/openff-bespokefit#369 openforcefield/openff-bespokefit#370
Relatively easy fix - make the db column not null, and the pydantic field not optional. A small validator is added to halp newer clients use older servers.
This is backwards compatible - new clients can use old servers, and old clients can still use new servers.
Status