Ability to specify times/durations in config as user-friendly strings#876
Merged
Ability to specify times/durations in config as user-friendly strings#876
Conversation
bennybp
force-pushed
the
config_duration
branch
from
ea45f56 to
8293f0f
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For various fields, the config requires you to specify the time something takes in seconds. This is not ideal for long durations (hours to days). This PR adds the ability to specify these in three ways:
90,"90"1:04:08:10(1 day, 4 hours, 8 minutes, 10 seconds)1d4h7s(1 day, 4 hours, 7 seconds)The conversion code is tolerant of leading zeros and weird quantities (ie,
1d77h99m99s)Status