Add ability to submit dataset records as a background job#881
Merged
Conversation
51237f0 to
282cf1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dataset.submit() can take a very long time for large datasets (large numbers of entries). A workaround is to batch entries and submit only a few at a time, something the dataset class does automatically.
This PR adds the ability to instead run the submission server-side. This creates an internal job on the server that does the actual submission, which you can then watch for progress.
Only one dataset submission will run at one time for a dataset, but you can submit multiple internal jobs if you want.
Status