Remove some fields from datasets - #911
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes 3 fields from the database and models. These fields were never really used, and the
groupfield causes some confusion about what it means.The fields:
metadatarenamed toextras-extraswas never able to be set or modified, butmetadatais confusinggroup- some sort of grouping available for the dataset. Superseded bytags(where each dataset can have multiple tags)visibility- meant to hid datasets from public view. Never implementedThese PR should be should be compatible with older clients for the time being. New clients won't work with old servers. Some future version will remove the compatibility with old clients completely.
The HTTP API has not changed, and is accepting of old clients. In addition, you may still access the
metadatafield of a the dataset class, which is transparently redirected toextras.Status