Skip to content

Rename tag and priority to compute_tag and compute_priority#913

Merged
bennybp merged 10 commits into
mainfrom
rename_tag_priority
Mar 27, 2025
Merged

Rename tag and priority to compute_tag and compute_priority#913
bennybp merged 10 commits into
mainfrom
rename_tag_priority

Conversation

@bennybp

@bennybp bennybp commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

Description

Renames tag and priority to compute_tag and compute_priority.

When dealing with datasets, tag is ambiguous - before this PR, datasets had a tagline, tags, and default_tag, where default_tag was something completely different from tags. This renames that to default_compute_tag

Also, priority can be difficult for new users to understand, so that is renamed to compute_priority (and default_compute_priority for datasets).

This also renames some function arguments and class attributes in managers. queue_tags in the config are now compute_tags to be consistent.

This changes quite a bit of code, but is fairly straightforward.

These changes are backwards compatible. Barring any bugs, old code (including currently-running managers) should continue to work. Old manager configs should also keep working.

Status

  • Code base linted
  • Ready to go

@bennybp bennybp changed the title Rename tag priority Rename tag and priority to compute_tag and compute_priority Mar 21, 2025
@bennybp bennybp merged commit 7f99ae3 into main Mar 27, 2025
@bennybp bennybp deleted the rename_tag_priority branch March 27, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant