Rename tag and priority to compute_tag and compute_priority#913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames
tagandprioritytocompute_tagandcompute_priority.When dealing with datasets,
tagis ambiguous - before this PR, datasets had atagline,tags, anddefault_tag, wheredefault_tagwas something completely different fromtags. This renames that todefault_compute_tagAlso,
prioritycan be difficult for new users to understand, so that is renamed tocompute_priority(anddefault_compute_priorityfor datasets).This also renames some function arguments and class attributes in managers.
queue_tagsin the config are nowcompute_tagsto be consistent.This changes quite a bit of code, but is fairly straightforward.
These changes are backwards compatible. Barring any bugs, old code (including currently-running managers) should continue to work. Old manager configs should also keep working.
Status