Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This renames "owner_user" to "creator_user" and removes the "owner_group" fields/functionality. This should largely be ok, as I don't think those features were really being used yet. On my own instances, groups have never been created.
The "creator_user" field is now just used to store who created a particular dataset/record, and should not be used in determining authorization.
This paves the way for more fine-grained permissions being implemented at the project level, rather than record and dataset level, which is far too granular IMO.
Lots of small changes on this one, but like previous PRs, trying to remain backwards compatible for the time being.
Status