Change how child records are stored (don't use PrivateAttr) - #967
Merged
Conversation
…get_cache_dict functions
Contributor
Author
|
I've given this a test with reading existing dataset view files, and it works for me. So as far as I can tell this is backwards compatible (as long as you are using the public API). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This changes the way child records are stored internally inside records. Before, they were stored as PrivateAttr, which means they were never serialized if you used pydantic's
dict()function.However, for saving/transferring/ingesting complete records, we want those child records in place. So this PR makes those child records regular fields.
However, we DON'T want those child records when writing to cache files (where they are handled differently). So a separate function was added for that.
Status