Skip to content

Sourcery Starbot ⭐ refactored MolarFox/PythonPractice #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sourcery Starbot ⭐ refactored MolarFox/PythonPractice #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CSV_JSON_converter/csv_json_conv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,4 @@ def csv2json(self):
pass


if __name__ == '__main__':
pass
pass
6 changes: 3 additions & 3 deletions password_gen/pass_gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ def _take_bool_input(self, prompt_txt):
val = input(prompt_txt + " (y/n): ")

# Try to parse user input
if (val == 'y') or (val == 'Y'):
if val in ['y', 'Y']:
return True
elif (val == 'n') or (val == 'N'):
elif val in ['n', 'N']:
Comment on lines -43 to +45
Copy link
Author

@SourceryAI SourceryAI Sep 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function PassGen._take_bool_input refactored with the following changes:

return False
else:
return None
Expand Down Expand Up @@ -122,7 +122,7 @@ def generate(self, count=1):
CHAR_RANGES[chosen_set][0],
CHAR_RANGES[chosen_set][1],
))
curr_pass = curr_pass + newchar
curr_pass += newchar
Copy link
Author

@SourceryAI SourceryAI Sep 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function PassGen.generate refactored with the following changes:

  • Replace assignment with augmented assignment (aug-assign)


passwords_out.append(curr_pass)
count -= 1
Expand Down