New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite #25

Merged
merged 111 commits into from May 8, 2013

Conversation

Projects
None yet
2 participants
@sun
Contributor

sun commented May 8, 2013

Here we go :)

As discussed, quite some changes + crazy hacks ;)

sun added some commits Jul 21, 2011

Major documentation and code clean-up. - Added phpDoc for class metho…
…ds. - Removed obsolete code and todos. - Renamed keyPublic and keyPrivate to pulicKey and privateKey. - Renamed $siteId to $publicKey. - Changed serversInit to rest.mollom.com.
Major documentation and code clean-up.
- Added phpDoc for class methods.
- Removed obsolete code and todos.
- Renamed keyPublic and keyPrivate to pulicKey and privateKey.
- Renamed $siteId to $publicKey.
- Changed serversInit to rest.mollom.com.
Issue #446994-26 by sun: Resolved remaining todos.
- Fixed Mollom class unit tests fail due to moved class file.
- Merged createBlacklistEntry() and updateBlacklistEntry() into saveBlacklistEntry().
- Fixed public methods should not throw MollomExceptions.
- Renamed getCaptcha() into createCaptcha().
- Moved generic handling of list responses into query().
- Fixed $next server to redirect to may be FALSE.
- Move current server to the start of the server list for subsequent requests.
- Renamed 'type' to 'severity' in log messages.
- Fixed stale reference to 'spam' response value.
- Changed visibility of configuration CRUD methods.
- Moved exception classes to the bottom.
- Added usage section to README.txt.
Issue #446994-26 by sun: Resolved remaining todos.
- Fixed Mollom class unit tests fail due to moved class file.
- Merged createBlacklistEntry() and updateBlacklistEntry() into saveBlacklistEntry().
- Fixed public methods should not throw MollomExceptions.
- Renamed getCaptcha() into createCaptcha().
- Moved generic handling of list responses into query().
- Fixed $next server to redirect to may be FALSE.
- Move current server to the start of the server list for subsequent requests.
- Renamed 'type' to 'severity' in log messages.
- Fixed stale reference to 'spam' response value.
- Changed visibility of configuration CRUD methods.
- Moved exception classes to the bottom.
- Added usage section to README.txt.
Resolved remaining todos.
Moved Mollom class into $form_state.
Added handling for list response meta properties.
Added {mollom}.solved and {mollom}.reason.
Fixed Blacklist tests for renamed context.
Resolved remaining todos. Moved Mollom class into $form_state. Added …
…handling for list response meta properties. Added {mollom}.solved and {mollom}.reason. Fixed Blacklist tests for renamed context.
Simplified response validation, removed arrayKeyExists() method, and …
…fixed 5xx response codes are always overridden to 511 (response error).
Simplified response validation, removed arrayKeyExists() method, and …
…fixed 5xx response codes are always overridden to 511 (response error).
Added deletion of server list when verifying keys, because of too fre…
…quent switching between XML-RPC and REST implementations during development.
Added deletion of server list when verifying keys, because of too fre…
…quent switching between XML-RPC and REST implementations during development.

sun added some commits May 6, 2013

@netsensei

This comment has been minimized.

Show comment
Hide comment
@netsensei

netsensei May 8, 2013

Contributor
  • 2,445 additions
  • 2,197 deletions

👍

I've skimmed through the code: it's well documented and succinctly written. I love the idea of the hook dispatcher to couple WP's hook architecture to a nice set of loosely coupled classes.

As discussed: I'm going to test this thoroughly.

Merging this. :-)

Contributor

netsensei commented May 8, 2013

  • 2,445 additions
  • 2,197 deletions

👍

I've skimmed through the code: it's well documented and succinctly written. I love the idea of the hook dispatcher to couple WP's hook architecture to a nice set of loosely coupled classes.

As discussed: I'm going to test this thoroughly.

Merging this. :-)

netsensei added a commit that referenced this pull request May 8, 2013

Merge pull request #25 from sun/rewrite
Rewritten: plugin architecture

@netsensei netsensei merged commit 0bfd1af into Mollom:master May 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment