Fixed up and down arrow. #1

merged 4 commits into from Mar 30, 2012


None yet

3 participants

swarley commented Mar 29, 2012

I didn't really change anything in your code, just a few tweaks with how the data was handled in history as far as accessing it. I believe I also added a call for end_of_line in the methods for retrieving the history. And it will remember the current line being typed in the history

cooper commented Mar 29, 2012

omg swarley r #1 accept the pull


This doesn't work here, and it breaks ^P and ^N too :

$ ruby repl.rb
>> 3                                                                                                     
=> 3
>> exit

where exit was produced by hitting either up arrow or ^P. It should be 3.

swarley added some commits Mar 30, 2012
@swarley swarley Making changes. 6e48756
@swarley swarley I believe i actually fixed it for real this time, after addressing Mo…
…n_Ouie's issues that I had overlooked. I would like people to test and comfirm this time before i request the merge.
swarley commented Mar 30, 2012

I see, I just spent time on it and I believe I addressed the issue. I'll have some people test it before I bother you again with a pull request.

swarley commented Mar 30, 2012

Yes, the up and down arrows do work as intended. I'm noticing the history is not loaded as it should be, or more specifically, it is not recorded. I will begin working on that now.

@Mon-Ouie Mon-Ouie merged commit 2c259ce into Mon-Ouie:master Mar 30, 2012

Thanks for the help, I merged this. ;)

swarley commented Mar 30, 2012

No problem, its very fun to read and modify your code. It is structured very well. Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment