Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make clean too eager #2680

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

make clean too eager #2680

monetdb-team opened this issue Nov 30, 2020 · 0 comments
Labels

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2010-10-02 00:31:57 +0200
From: Alexandr Kulik <<alexandr.kulik1988>>
To: MonetDB5 devs <>
Version: 5.22.1 (Oct2010) [obsolete]
CC: @drstmane

Last updated: 2011-03-28 17:31:27 +0200

Comment 14954

Date: 2010-10-02 00:31:57 +0200
From: Alexandr Kulik <<alexandr.kulik1988>>

User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_4; en-US) AppleWebKit/534.3 (KHTML, like Gecko) Chrome/6.0.472.63 Safari/534.3
Build Identifier:

Compilation problem with Jun2010 version of MonetDB sources. For Nov2010 this error never happens.

Reproducible: Always

Steps to Reproduce:

Pull Jun2010 sources from mercurial.
Try to build them.
See an error on MonetDB5 module.

Actual Results:

Please se an attachments. I put there bootstrap, configure and make execution output.

Have the same error on MacOS Snow Leopard 10.6.4 and CentOS5.5

Comment 14955

Date: 2010-10-02 00:32:43 +0200
From: Alexandr Kulik <<alexandr.kulik1988>>

Created attachment 38
bootstrap output

Attached file: bootstrap.txt (text/plain, 1796 bytes)
Description: bootstrap output

Comment 14956

Date: 2010-10-02 00:33:08 +0200
From: Alexandr Kulik <<alexandr.kulik1988>>

Created attachment 39
configure output

Attached file: configure.txt (text/plain, 14764 bytes)
Description: configure output

Comment 14957

Date: 2010-10-02 00:33:29 +0200
From: Alexandr Kulik <<alexandr.kulik1988>>

Created attachment 40
Make output

Attached file: make.txt (text/plain, 158551 bytes)
Description: Make output

Comment 14958

Date: 2010-10-02 07:39:22 +0200
From: @drstmane

May I assume that you call configure directly in the checked-out source tree?
Could you please try to call configure in a separately created build directory (one per package that you compile) as our documentation recommends?
The latter appears to work fine for us (we admittedly never test the former) ...

Comment 14959

Date: 2010-10-03 18:23:24 +0200
From: Alexandr Kulik <<alexandr.kulik1988>>

Got the same problem when execute (configure) from other directory.

(In reply to comment 4)

May I assume that you call configure directly in the checked-out source tree?
Could you please try to call configure in a separately created build directory
(one per package that you compile) as our documentation recommends?
The latter appears to work fine for us (we admittedly never test the former)
...

Comment 14960

Date: 2010-10-03 19:47:08 +0200
From: @grobian

Can you please try the Oct2010 branch instead? Jun2010 is no longer maintained.
I don't expect it to solve the issue, but just to be sure.

/Developer/monetsrc/workspace/MonetDB-Jun2010/out/bin/Mx -x c mal_io.mx
mal_io.mx: ./mal_io.c - created
/Developer/monetsrc/workspace/MonetDB-Jun2010/out/bin/Mx -l -x h mal_io.mx
mal_io.mx: ./mal_io.h - created
make[6]: *** No rule to make target 30_xml.mal', needed by all'. Stop.
make[5]: *** [all-recursive] Error 1
make[4]: *** [all] Error 2
make[3]: *** [all-recursive] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
kulya's:MonetDB5 kulya$

Comment 14961

Date: 2010-10-03 19:58:09 +0200
From: Alexandr Kulik <<alexandr.kulik1988>>

Oct2010 works fine for me. But i need to use Jun2010 because of issue 2670 (http://bugs.monetdb.org/show_bug.cgi?id=2670).

(In reply to comment 6)

Can you please try the Oct2010 branch instead? Jun2010 is no longer
maintained.
I don't expect it to solve the issue, but just to be sure.

/Developer/monetsrc/workspace/MonetDB-Jun2010/out/bin/Mx -x c mal_io.mx
mal_io.mx: ./mal_io.c - created
/Developer/monetsrc/workspace/MonetDB-Jun2010/out/bin/Mx -l -x h mal_io.mx
mal_io.mx: ./mal_io.h - created
make[6]: *** No rule to make target 30_xml.mal', needed by all'. Stop.
make[5]: *** [all-recursive] Error 1
make[4]: *** [all] Error 2
make[3]: *** [all-recursive] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
kulya's:MonetDB5 kulya$

Comment 14963

Date: 2010-10-03 20:08:19 +0200
From: @grobian

Jun2010 branch is in a broken, and won't get any releases any more. I marked the other bug as a blocker.

Comment 14968

Date: 2010-10-04 11:43:04 +0200
From: @sjoerdmullender

The file 30_xml.mal was added to the repository in the Jun2010 branch on June 23 which was before we created the Jun2010 release.

My guess is, you did a "make clean" in your MonetDB5 directory. It seems that is a bit too eager and removes this file. Check the output of "hg status" and you'll probably see that it complains about that file.

Comment 14976

Date: 2010-10-05 16:28:13 +0200
From: @sjoerdmullender

I'm changing the summary to what I think is the real problem.
Also, I think I fixed the problem. The next comment will mention the changeset which I am about to commit.

Comment 14977

Date: 2010-10-05 16:29:22 +0200
From: @sjoerdmullender

Changeset e932da9a114b made by Sjoerd Mullender sjoerd@acm.org in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=e932da9a114b

Changeset description:

If a header is conditionally used, don't unconditionally remove it in make clean.
This should fix bug #2680, except that bug involves a file that is no
longer present in this branch.

Comment 15220

Date: 2010-11-24 10:21:03 +0100
From: @sjoerdmullender

Changeset 00170285ca64 made by Sjoerd Mullender sjoerd@acm.org in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=00170285ca64

Changeset description:

Cleaned up cleaning up.
`make clean' should clean up to a state that everything that you would
normally want rebuilt using `make' gets removed, and in such a way
that there is no need to run configure again.
`make distclean' should clean up everything that is not part of the
sources, so that you do have to run configure again.
This is complicated by the fact that we need to distinguish between
sources from Mercurial or sources from a tar ball distribution.
In a Makefile.am file you can set variables MOSTLYCLEANFILES to add
files to the `make clean' scenario that automake doesn't know about.
Before, all files in BUILT_SOURCES were added.  BUILT_SOURCES
basically contains generated source files.  But in the tar ball
scenario, many of those generated source files were part of the tar
ball and hence should not be removed by `make clean'.
So now we add files explicitly:  In am.py there is a variable
am['CLEAN'] that contains the files that have to always be removed
using `make clean' (i.e. files that are not part of the tar ball), and
a variable am['MXCLEAN'] that contains files that should be removed
only when building from Mercurial sources (i.e. generated source
files).

Most of the rest of the changes is just fine-tuning what gets removed
and making sure that configure itself doesn't leave behind junk.

Hopefully this fixes bug #2680.  Unfortunately, I did not receive
confirmation that my analysis of the bug was correct, so I can't be
sure.

Comment 15409

Date: 2011-01-24 14:08:08 +0100
From: @grobian

I hope Sjoerd's fixes were sufficient. Please reopen, if not.

Comment 15621

Date: 2011-03-28 17:31:27 +0200
From: @sjoerdmullender

The Mar2011 version has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant