Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CALL function without warning #2752

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

CALL function without warning #2752

monetdb-team opened this issue Nov 30, 2020 · 0 comments
Labels

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2010-12-12 22:34:09 +0100
From: @mlkersten
To: SQL devs <>
Version: -- development
CC: @njnes

Last updated: 2011-03-28 17:31:43 +0200

Comment 15338

Date: 2010-12-12 22:34:09 +0100
From: @mlkersten

User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13
Build Identifier:

In SQL the CALL does not produce a response, which is 'ok', because functions are not supposed to have side effects. But, perhaps this should be announced with a message. Alternatively, CALL could be interpreted similar to SELECT .

Reproducible: Always

Steps to Reproduce:

1.call sin(1.0)
2.
3.

Actual Results:

sql>call sin(1.0);
sql>debug call sin(1.0);
mdb> mdb.start();
mdb>l
1 mdb.start();
2 user.s0_1(1);
3 mdb.stop();
4 end main;
mdb>l user.s0_1
0 function user.s0_1(A0);
1 sql.mvc();
2 end s0_1;
mdb>q

Expected Results:

sql>call sin(1.0);
SQLerror, function calls are ignored

sql>call sin(1,0)
+------------------------+
| sin_single_value |
+========================+
| 0.8414709848078965 |
+------------------------+

Comment 15341

Date: 2010-12-13 20:44:38 +0100
From: @njnes

fixed by checking for 'no' result in psm_call

Comment 15342

Date: 2010-12-13 20:45:13 +0100
From: @njnes

Changeset 5557a44861ad made by Niels Nes niels@cwi.nl in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=5557a44861ad

Changeset description:

fix for Bug #2752
ie check for procedures in 'call'.

Comment 15656

Date: 2011-03-28 17:31:43 +0200
From: @sjoerdmullender

The Mar2011 version has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant