Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest antiselect changes cause ~20 SQL tests to fail #2796

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

latest antiselect changes cause ~20 SQL tests to fail #2796

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2011-04-03 20:34:06 +0200
From: @drstmane
To: GDK devs <>
Version: 11.1.1 (Mar2011) [obsolete]

Last updated: 2011-04-28 16:25:36 +0200

Comment 15713

Date: 2011-04-03 20:34:06 +0200
From: @drstmane

I just happened to notice this, but had no time, yet to look into the details ...

The antiselect fix (cf., http://dev.monetdb.org/hg/MonetDB/rev/d7c2f5b1eafa) causes ~20 SQL tests to fail as follows.
The tests fail like this on both the Mar2011 branch and the Apr2011 branch.
Some of these failures, i.e., differences between stable and latest output, might be due to the stable output being wrongly approved in the first place.

ERROR = !MALException:!ERROR: BATpropcheck: BAT tmpr_1426(-790)[int,void] with 2 tuples was incorrectly marked keyed!
(or alike):

http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/BugTracker-2009/mclient-lsql-D.err.diff.html
http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/BugTracker-2009/not_equal.SF-2678502.err.diff.html
http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/BugTracker-2009/name_clash_with_dump.SF-2780395.err.diff.html
http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/Dump/dump-empty.err.diff.html
http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/Dump/dump.err.diff.html
http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/antiselect.err.diff.html
http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/BugDay_2005-10-06_2.8/MapiClient-dump.SF-905851.err.diff.html
http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/BugTracker/multi-column-constraint.SF-1964587.err.diff.html

Different/extra output (partly possibly left-overs after/due to earlier tests failing):

http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/UserDump/create.out.diff.html
http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/bugs/select_not_equal.out.diff.html
http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/pg_regress/char.out.diff.html
http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/pg_regress/varchar.out.diff.html
http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/benchmarks/ATIS/select_group.out.diff.html
http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/benchmarks/tpch/16.out.diff.html
http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/benchmarks/tpch/01-22.out.diff.html
http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/benchmarks/tpch/LOCKED/16.out.diff.html
http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/benchmarks/tpch/LOCKED/01-22.out.diff.html

Errors / transaction aborts (possibly due to earlier tests failing):

http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/Dump/reload.err.diff.html
http://monetdb.cwi.nl/testing/projects/monetdb/testweb/tests/39711:af22bd4fe8ff/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/Dump/test.err.diff.html

Comment 15714

Date: 2011-04-04 10:28:46 +0200
From: @sjoerdmullender

Changeset 932a58fecbde made by Sjoerd Mullender sjoerd@acm.org in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=932a58fecbde

Changeset description:

Include boundaries in anti point select so that they get excluded by the anti part.
This fixes bug #2796.

Comment 15716

Date: 2011-04-04 19:31:53 +0200
From: @grobian

This is the difference between the run before and after the commit, as well as after the fix (when it comes available, the third column will be added), which should be a visual version of the analysis given by Stefan :)

http://monetdb.cwi.nl/testing/projects/monetdb/testweb/web/testgrid.php?serial=39726:4573990d7651,39711:af22bd4fe8ff,39693:809990fb1014&module=sql&targets=GNU-Fedora-x86_64-propcheck&order=platform,arch,compiler

Comment 15718

Date: 2011-04-05 11:03:56 +0200
From: @grobian

please discard comparison from comment 2, use this one instead:

http://monetdb.cwi.nl/testing/projects/monetdb/testweb/web/testgrid.php?serial=39726:4573990d7651,39711:af22bd4fe8ff,39693:809990fb1014&module=sql&targets=GNU-Fedora-x86_64-dist-rpm&order=platform,arch,compiler

It shows everything is back to normal again.

Comment 15721

Date: 2011-04-05 12:43:10 +0200
From: @drstmane

Indeed, the tests work fine, again.

Thanks to Sjoerd for spotting and fixing the bug!

Thanks to Fabian for providing a convenient and helpful interface to double-check!

Closing.

Comment 15748

Date: 2011-04-28 16:25:36 +0200
From: @sjoerdmullender

The Apr2011 release has been uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant