Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy into should rollback correctly (i.e. restore the files) on a failure #2810

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2011-05-13 20:52:57 +0200
From: Holger <<holger.pirk>>
To: SQL devs <>
Version: -- development
CC: @njnes

Last updated: 2011-05-31 13:59:27 +0200

Comment 15805

Date: 2011-05-13 20:52:57 +0200
From: Holger <<holger.pirk>>

User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_7; en-us) AppleWebKit/533.21.1 (KHTML, like Gecko) Version/5.0.5 Safari/533.21.1
Build Identifier:

Binary copy of variable sized data doesn't work. This is, however, only checked when actually importing into the variable sized column. All files that were imported in the same statement but before the variable sized column import are moved from their original position in the file system.

Reproducible: Always

Steps to Reproduce:

  1. Create a table with one fixed width and one variable width column
  2. Do a copy into with binary data.

Actual Results:

mclient output: ERROR: BATattach: bad tail type (varsized)
File with fixed width data is gone

Expected Results:

mclient output: ERROR: BATattach: bad tail type (varsized)
File with fixed width data is not gone

Comment 15807

Date: 2011-05-16 21:40:32 +0200
From: @njnes

could you add an sql example

Comment 15808

Date: 2011-05-16 21:50:36 +0200
From: @njnes

fixed by checking first if we may load variable sized types. (if we fail for another reason, we still won't move the files back (ie be carefull when using this feature)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant